Skip to content

Conversation

knassre-bodo
Copy link
Contributor

@knassre-bodo knassre-bodo commented Apr 21, 2025

Includes documentation for the various IRs and conversions between them. The page still has several major TODO sections that need to be filled out, but this PR fills out the following:

  • Table of contents and overall structure of the page
  • Overview section with flowchart explaining how the pieces fit together
  • Entirety of the UnqualifiedNode and unqualified transform sections
  • Part of the QDAG node sections, with a diagram showing how an earlier unqualified node looks like as QDAG nodes
  • Much of the hybrid tree sections on hybrid conversion & de-correlation with in-depth diagrams
  • Part of the relational tree section showing what an earlier example looks like as a relational tree

The markdown page for the IRs includes mermaid diagrams which should render normally on the GitHub UI, or in VSCode if an extension is installed.

@knassre-bodo knassre-bodo changed the title Create documentation for internal workings of PyDough Start documentation for internal workings of PyDough Apr 28, 2025
@knassre-bodo knassre-bodo requested a review from hadia206 April 28, 2025 03:50
@knassre-bodo knassre-bodo marked this pull request as ready for review April 28, 2025 03:50
Copy link
Contributor

@hadia206 hadia206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Kian.
Please see my comments below

knassre-bodo and others added 2 commits May 6, 2025 12:16
Adding Hadia's revisions

Co-authored-by: Hadia Ahmed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants